Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kernel and line info in cmake #3941

Merged
merged 12 commits into from
Jun 9, 2021
Merged

Fix kernel and line info in cmake #3941

merged 12 commits into from
Jun 9, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jun 3, 2021

Closes #3938

@dantegd dantegd added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 3, 2021
@dantegd dantegd requested review from a team as code owners June 3, 2021 15:50
@dantegd dantegd added this to PR-WIP in v21.08 Release via automation Jun 3, 2021
@mdoijade
Copy link
Contributor

mdoijade commented Jun 8, 2021

@dantegd I believe this similar lineinfo / kernelinfo change is required in RAFT cmake as well. I am unable to get lineinfo enabled in RAFT testsuite.
@vinaydes for visibility.

ajschmidt8
ajschmidt8 reviewed Jun 8, 2021
View reviewed changes
ci/gpu/build.sh Outdated
"rapids-build-env=${MINOR_VERSION}.*" \
"rapids-notebook-env=${MINOR_VERSION}.*" \
"rapids-doc-env=${MINOR_VERSION}.*" \
"shap>=0.37,<=0.39"
# "xgboost=1.4.2dev.rapidsai${MINOR_VERSION}" \
Copy link
Member

@ajschmidt8 ajschmidt8 Jun 8, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xgboost 1.4.2 packages for 21.08 have just been published. you should be okay to uncomment this line (assuming this was only a temporary comment).

https://anaconda.org/rapidsai-nightly/xgboost/files?version=1.4.2dev.rapidsai21.08

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it was temporary just to test CI of 21.08

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajschmidt8 corrected this, could use your review/approval to merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@3eec43d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #3941   +/-   ##
===============================================
  Coverage                ?   85.13%           
===============================================
  Files                   ?      230           
  Lines                   ?    18138           
  Branches                ?        0           
===============================================
  Hits                    ?    15441           
  Misses                  ?     2697           
  Partials                ?        0
Flag Coverage Δ
dask 47.80% <0.00%> (?)
non-dask 77.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eec43d...71e0685. Read the comment docs.

cjnolet
cjnolet approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dantegd
Copy link
Member Author

dantegd commented Jun 9, 2021

@gpucibot merge

@levsnv levsnv mentioned this pull request Jun 9, 2021
Merged
@mdoijade mdoijade mentioned this pull request Jun 9, 2021
Merged
v21.08 Release automation moved this from PR-WIP to PR-Reviewer approved Jun 9, 2021
@rapids-bot rapids-bot bot merged commit 74aaf05 into rapidsai:branch-21.08 Jun 9, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done Jun 9, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Fix kernel and line info in cmake (rapidsai#3941)
07254db 
Closes rapidsai#3938

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#3941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis left review comments

@cjnolet cjnolet cjnolet approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CUDA/C++ gpuCI gpuCI issue non-breaking Non-breaking change
Projects
No open projects
v21.08 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CUDA lineinfo and kernel info is not generated by current cmake build
6 participants
@dantegd @mdoijade @codecov-commenter @cjnolet @ajschmidt8 @trivialfis