Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Exposing condensed hierarchy through cython for easier unit-level testing #4004

Merged
merged 8 commits into from
Jul 11, 2021
Merged

[REVIEW] Exposing condensed hierarchy through cython for easier unit-level testing #4004

merged 8 commits into from
Jul 11, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jun 22, 2021

No description provided.

@cjnolet cjnolet requested review from a team as code owners June 22, 2021 22:50
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Jun 22, 2021
@cjnolet cjnolet added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Tech Debt Issues related to debt tests Unit testing for project and removed CUDA/C++ Cython / Python Cython or Python issue labels Jun 22, 2021
@cjnolet cjnolet added this to PR-WIP in v21.08 Release via automation Jun 22, 2021
@cjnolet cjnolet mentioned this pull request Jun 22, 2021
Open
21 tasks
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Jun 22, 2021
@cjnolet cjnolet changed the title [WIP] Exposing condensed hierarchy through cython for easier unit-level testing [REVIEW] Exposing condensed hierarchy through cython for easier unit-level testing Jul 9, 2021
@cjnolet cjnolet added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Jul 9, 2021
divyegala
divyegala approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@964f40e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4004   +/-   ##
===============================================
  Coverage                ?   85.52%           
===============================================
  Files                   ?      230           
  Lines                   ?    18221           
  Branches                ?        0           
===============================================
  Hits                    ?    15583           
  Misses                  ?     2638           
  Partials                ?        0
Flag Coverage Δ
dask 48.14% <0.00%> (?)
non-dask 77.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964f40e...a4d0ee1. Read the comment docs.

@cjnolet cjnolet moved this from PR-WIP to PR-Reviewer approved in v21.08 Release Jul 10, 2021
@dantegd
Copy link
Member

dantegd commented Jul 11, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit aadbb19 into rapidsai:branch-21.08 Jul 11, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done Jul 11, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Exposing condensed hierarchy through cython for easier unit-level tes…
927b735 
…ting (rapidsai#4004)

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Tech Debt Issues related to debt tests Unit testing for project
Projects
No open projects
v21.08 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjnolet @codecov-commenter @dantegd @divyegala