Small ARIMA-related bug fixes in Hessenberg reduction and make_arima #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyrio
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #4017 +/- ##
===============================================
Coverage ? 85.47%
===============================================
Files ? 230
Lines ? 18130
Branches ? 0
===============================================
Hits ? 15496
Misses ? 2634
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dantegd
approved these changes
Jul 1, 2021
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…apidsai#4017) I'm batching two small bug fixes in one PR: - A race condition in the Hessenberg reduction used when solving the Lyapunov equation used to initialize the Kalman filter for ARIMA. - In `make_arima` there are reads of uninitialized memory (though the result of these reads is never used so it's not exactly a bug, but the compute sanitizer complains so it's worth fixing with a placeholder initialization) Authors: - Louis Sugy (https://github.com/Nyrio) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm batching two small bug fixes in one PR:
make_arimathere are reads of uninitialized memory (though the result of these reads is never used so it's not exactly a bug, but the compute sanitizer complains so it's worth fixing with a placeholder initialization)