[FIX] Add Treelite_BINARY_DIR include to cuml++ build interface include paths
#4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trxcllnt Should I update CMakeLists.txt of Treelite to change |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #4018 +/- ##
===============================================
Coverage ? 85.47%
===============================================
Files ? 230
Lines ? 18130
Branches ? 0
===============================================
Hits ? 15496
Misses ? 2634
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dantegd
approved these changes
Jul 1, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 2, 2021
Follow-up to #4018, but this time it actually works. Makes `${Treelite_SOURCE_DIR}/include` part of the build interface so users consuming an installed `cuml++` don't get an include path to the build dir. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #4023
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…aths (rapidsai#4018) This PR fixes an issue causing cuML source builds to fail when CPM adds Treelite. Treelite's generated include path isn't in their `INTERFACE_INCLUDE_DIRECTORIES`, so this path isn't added to the `cuml++` target's include dirs either. The fix is to add Treelite's generated include path to the `cuml++` target. ```shell In file included from _deps/cuml-src/cpp/src/decisiontree/decisiontree_impl.cuh:20, from _deps/cuml-src/cpp/src/decisiontree/decisiontree.cu:22: _deps/treelite-src/include/treelite/tree.h:11:10: fatal error: treelite/version.h: No such file or directory 11 | #include <treelite/version.h> ``` Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4018
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Follow-up to rapidsai#4018, but this time it actually works. Makes `${Treelite_SOURCE_DIR}/include` part of the build interface so users consuming an installed `cuml++` don't get an include path to the build dir. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue causing cuML source builds to fail when CPM adds Treelite.
Treelite's generated include path isn't in their
INTERFACE_INCLUDE_DIRECTORIES, so this path isn't added to thecuml++target's include dirs either. The fix is to add Treelite's generated include path to thecuml++target.In file included from _deps/cuml-src/cpp/src/decisiontree/decisiontree_impl.cuh:20, from _deps/cuml-src/cpp/src/decisiontree/decisiontree.cu:22: _deps/treelite-src/include/treelite/tree.h:11:10: fatal error: treelite/version.h: No such file or directory 11 | #include <treelite/version.h>