Fixing intermittent HBDSCAN pytest failure in CI #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
3 - Ready for Review
21 tasks
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #4025 +/- ##
===============================================
Coverage ? 85.46%
===============================================
Files ? 230
Lines ? 18133
Branches ? 0
===============================================
Hits ? 15498
Misses ? 2635
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cjnolet
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
LGTM. Thanks for chasing this down, Divye. The assumptions and expectations in the fused l2 knn primitive are not clearly noted anywhere and it's been a bit of challenge to decompose them while customizing the k-select behavior for the reachability distances in hdbscan.
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
closes #4025 again. This is happening because the underlying assumptions in the fused-1nn have likely changed, and that trickles down to HDBSCAN and the functors we use for accessing that API - as discussed with @cjnolet Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #4052
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
There was an OOB access occurring here https://github.com/rapidsai/cuml/blob/0707a46f717023ca0b5047c3aeee9ead1a093272/cpp/src/hdbscan/runner.h#L74 when `b.key == 1`. This error was getting swallowed up and we were seeing those `thrust::transform` errors in CI. Tagging @cjnolet to confirm if this is the intended way to use this functor and the fix is correct. Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4025
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
closes rapidsai#4025 again. This is happening because the underlying assumptions in the fused-1nn have likely changed, and that trickles down to HDBSCAN and the functors we use for accessing that API - as discussed with @cjnolet Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an OOB access occurring here
cuml/cpp/src/hdbscan/runner.h
Line 74 in f7fb363
b.key == 1. This error was getting swallowed up and we were seeing thosethrust::transformerrors in CI.Tagging @cjnolet to confirm if this is the intended way to use this functor and the fix is correct.