Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable installing gbench to avoid container permission issues #4049

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jul 13, 2021

cc @wphicks this should fix our issue in the nightly containers

@dantegd dantegd added bug Something isn't working 2 - In Progress Currenty a work in progress labels Jul 13, 2021
@dantegd dantegd added this to PR-WIP in v21.08 Release via automation Jul 13, 2021
@dantegd dantegd added the non-breaking Non-breaking change label Jul 13, 2021
@dantegd dantegd closed this Jul 13, 2021
v21.08 Release automation moved this from PR-WIP to Done Jul 13, 2021
@dantegd dantegd reopened this Jul 13, 2021
v21.08 Release automation moved this from Done to PR-WIP Jul 13, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@c9abba1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4049   +/-   ##
===============================================
  Coverage                ?   85.59%           
===============================================
  Files                   ?      230           
  Lines                   ?    18221           
  Branches                ?        0           
===============================================
  Hits                    ?    15596           
  Misses                  ?     2625           
  Partials                ?        0           
Flag Coverage Δ
dask 48.14% <0.00%> (?)
non-dask 77.92% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9abba1...e31181e. Read the comment docs.

@dantegd dantegd marked this pull request as ready for review July 13, 2021 22:07
@dantegd dantegd requested a review from a team as a code owner July 13, 2021 22:07
@dantegd dantegd added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Jul 13, 2021
v21.08 Release automation moved this from PR-WIP to PR-Reviewer approved Jul 14, 2021
@dantegd
Copy link
Member Author

dantegd commented Jul 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 16dbaa8 into rapidsai:branch-21.08 Jul 15, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done Jul 15, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
…sai#4049)

cc @wphicks  this should fix our issue in the nightly containers

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Robert Maynard (https://github.com/robertmaynard)

URL: rapidsai#4049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CUDA/C++ non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants