Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix train test split pytest comparison #4062

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Fix train test split pytest comparison #4062

merged 1 commit into from
Jul 17, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jul 16, 2021

Unblocks CI

@dantegd dantegd added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jul 16, 2021
@dantegd dantegd added this to PR-WIP in v21.08 Release via automation Jul 16, 2021
@dantegd dantegd requested a review from a team as a code owner July 16, 2021 22:02
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 16, 2021
wphicks
wphicks approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For my own reference, do you happen to know which PR it was that made this necessary?

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@eaa2add). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4062   +/-   ##
===============================================
  Coverage                ?   85.60%           
===============================================
  Files                   ?      230           
  Lines                   ?    18221           
  Branches                ?        0           
===============================================
  Hits                    ?    15598           
  Misses                  ?     2623           
  Partials                ?        0
Flag Coverage Δ
dask 48.14% <0.00%> (?)
non-dask 78.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa2add...defcc55. Read the comment docs.

cjnolet
cjnolet approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v21.08 Release automation moved this from PR-WIP to PR-Reviewer approved Jul 17, 2021
@cjnolet
Copy link
Member

cjnolet commented Jul 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3c11ebd into rapidsai:branch-21.08 Jul 17, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done Jul 17, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Fix train test split pytest comparison (rapidsai#4062)
c3c4376 
Unblocks CI

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
v21.08 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dantegd @codecov-commenter @cjnolet @wphicks