Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Apply modifications to account for RAFT changes #4077

Merged
merged 46 commits into from
Aug 30, 2021

Conversation

@viclafargue viclafargue requested review from a team as code owners July 21, 2021 14:35
@viclafargue viclafargue changed the base branch from branch-21.08 to branch-21.10 July 21, 2021 14:36
@viclafargue viclafargue added breaking Breaking change improvement Improvement / enhancement to an existing function labels Jul 21, 2021
@dantegd dantegd added the 2 - In Progress Currenty a work in progress label Jul 21, 2021
@ajschmidt8 ajschmidt8 removed the request for review from a team July 21, 2021 17:25
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

Also, please consider using Draft pull requests instead of the WIP tag for PRs that are still in progress. Draft pull requests have the advantage of not notifying codeowners until the PR is marked Ready for Review.

For reference here's the GitHub docs on draft pull requests: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests

@caryr35 caryr35 added this to PR-WIP in v21.10 Release via automation Jul 21, 2021
@github-actions github-actions bot removed the conda conda issue label Jul 27, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Aug 4, 2021
@viclafargue viclafargue requested a review from a team as a code owner August 9, 2021 13:21
@dantegd
Copy link
Member

dantegd commented Aug 26, 2021

rerun tests

2 similar comments
@dantegd
Copy link
Member

dantegd commented Aug 26, 2021

rerun tests

@viclafargue
Copy link
Contributor Author

rerun tests

@dantegd
Copy link
Member

dantegd commented Aug 26, 2021

@viclafargue I think the only issue remaining to pass CI is correcting C++ docstrings!!!

Generating docs for file /workspace/cpp/src_prims/metrics/silhouette_score.cuh/workspace/cpp/include/cuml/tsa/arima_common.h:67: error: 
argument 'alloc' of command @param is not found in the argument list of ML::ARIMAParams< DataT >::allocate(const 
ARIMAOrder &order, int batch_size, cudaStream_t stream, bool tr=false) (warning treated as error, aborting now)

...

@github-actions github-actions bot removed the conda conda issue label Aug 27, 2021
@dantegd
Copy link
Member

dantegd commented Aug 27, 2021

rerun tests

v21.10 Release automation moved this from PR-Needs review to PR-Reviewer approved Aug 29, 2021
@github-actions github-actions bot removed the gpuCI gpuCI issue label Aug 29, 2021
@dantegd
Copy link
Member

dantegd commented Aug 30, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@8b6bd1c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #4077   +/-   ##
===============================================
  Coverage                ?   85.96%           
===============================================
  Files                   ?      232           
  Lines                   ?    18502           
  Branches                ?        0           
===============================================
  Hits                    ?    15906           
  Misses                  ?     2596           
  Partials                ?        0           
Flag Coverage Δ
dask 47.77% <0.00%> (?)
non-dask 78.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6bd1c...47c4b6b. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Aug 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 903d576 into rapidsai:branch-21.10 Aug 30, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Aug 30, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This PR apply modifications to the cuML codebase to account for changes in RAFT and RMM :
- rapidsai/raft#283
- rapidsai/raft#285
- rapidsai/raft#286
- rapidsai/rmm#816

Authors:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Divye Gala (https://github.com/divyegala)

URL: rapidsai#4077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants