Correct name of a cmake function in get_spdlog.cmake #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
3 - Ready for Review
dantegd
requested changes
Jul 27, 2021
dantegd
added
4 - Waiting on Author
|
I targeted the wrong branch. These changes are not high priority since no actual problem exists, just bad names. I switched over to targeting the 21.10 branch. |
robertmaynard
added
3 - Ready for Review
dantegd
approved these changes
Jul 27, 2021
ajschmidt8
approved these changes
Jul 28, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #4106 +/- ##
===============================================
Coverage ? 85.81%
===============================================
Files ? 232
Lines ? 18252
Branches ? 0
===============================================
Hits ? 15663
Misses ? 2589
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Correct a copy and paste error in `get_spdlog.cmake` Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - AJ Schmidt (https://github.com/ajschmidt8) URL: rapidsai#4106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct a copy and paste error in
get_spdlog.cmake