Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Running umap mnmg test twice #4112

Merged
merged 1 commit into from
Jul 28, 2021
Merged

[REVIEW] Running umap mnmg test twice #4112

merged 1 commit into from
Jul 28, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jul 27, 2021

No description provided.

@cjnolet cjnolet added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jul 27, 2021
@cjnolet cjnolet added this to PR-WIP in v21.08 Release via automation Jul 27, 2021
@cjnolet cjnolet requested a review from a team as a code owner July 27, 2021 21:38
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 27, 2021
v21.08 Release automation moved this from PR-WIP to PR-Reviewer approved Jul 27, 2021
@dantegd
Copy link
Member

dantegd commented Jul 27, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@804b5e6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4112   +/-   ##
===============================================
  Coverage                ?   85.83%           
===============================================
  Files                   ?      231           
  Lines                   ?    18264           
  Branches                ?        0           
===============================================
  Hits                    ?    15676           
  Misses                  ?     2588           
  Partials                ?        0
Flag Coverage Δ
dask 48.18% <0.00%> (?)
non-dask 78.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804b5e6...e38b0ab. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 8c96f9a into rapidsai:branch-21.08 Jul 28, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done Jul 28, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Running umap mnmg test twice (rapidsai#4112)
5d20c87 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
v21.08 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjnolet @dantegd @codecov-commenter