Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Remove max version pin for dask & distributed on development branch #4118

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR will remove max version pinning for dask & distributed for development purposes.

ref: rapidsai/cudf#8881

@galipremsagar galipremsagar requested a review from a team as a code owner July 28, 2021 15:37
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Jul 28, 2021
@galipremsagar
Copy link
Contributor Author

Needs appropriate labeling and project scoping as I don't have write permissions in this repo.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 28, 2021
Comment on lines -125 to +126
pip install "git+https://github.com/dask/distributed.git@2021.07.1" --upgrade --no-deps
pip install "git+https://github.com/dask/dask.git@2021.07.1" --upgrade --no-deps
pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps
pip install "git+https://github.com/dask/dask.git@main" --upgrade --no-deps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should do something like this ( rapidsai/dask-cuda@855eeac ) to simplify this process

@dantegd
Copy link
Member

dantegd commented Jul 28, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@caf3058). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #4118   +/-   ##
===============================================
  Coverage                ?   85.83%           
===============================================
  Files                   ?      231           
  Lines                   ?    18264           
  Branches                ?        0           
===============================================
  Hits                    ?    15676           
  Misses                  ?     2588           
  Partials                ?        0           
Flag Coverage Δ
dask 48.18% <0.00%> (?)
non-dask 78.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf3058...48c0c80. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 96ef38c into rapidsai:branch-21.10 Jul 28, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
…ch (rapidsai#4118)

This PR will remove max version pinning for dask & distributed for development purposes.

ref: rapidsai/cudf#8881

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - https://github.com/jakirkham

URL: rapidsai#4118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants