[bug-fix] avoid paramsSolver::{n_rows,n_cols} shadowing their base class counterparts #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yitao Li <yitao@rstudio.com>
yitao-li
changed the title
|
Can one of the admins verify this patch? |
|
ok to test |
yitao-li
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #4130 +/- ##
===============================================
Coverage ? 85.91%
===============================================
Files ? 232
Lines ? 18377
Branches ? 0
===============================================
Hits ? 15788
Misses ? 2589
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
lowener
approved these changes
Aug 19, 2021
dantegd
approved these changes
Sep 14, 2021
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…rparts (rapidsai#4130) This looks to me like a typo, and may be problematic and confusing if the `n_rows` and `n_cols` members from the base class instead of the ones from the derived class are accessed. Signed-off-by: Yitao Li <yitao@rstudio.com> Authors: - Yitao Li (https://github.com/yitao-li) Approvers: - Micka (https://github.com/lowener) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks to me like a typo, and may be problematic and confusing if the
n_rowsandn_colsmembers from the base class instead of the ones from the derived class are accessed.Signed-off-by: Yitao Li yitao@rstudio.com