Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log level for dask tree_reduce #4163

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix log level for dask tree_reduce #4163

merged 1 commit into from
Sep 7, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Aug 16, 2021

Closes #4153.

@lowener lowener requested a review from a team as a code owner August 16, 2021 01:11
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Aug 16, 2021
@lowener lowener added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 16, 2021
@lowener
Copy link
Contributor Author

lowener commented Aug 16, 2021

rerun tests

@lowener lowener added the 3 - Ready for Review Ready for review by team label Aug 16, 2021
@caryr35 caryr35 added this to PR-WIP in v21.10 Release via automation Aug 18, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v21.10 Release Aug 18, 2021
@lowener
Copy link
Contributor Author

lowener commented Sep 5, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@e86a613). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #4163   +/-   ##
===============================================
  Coverage                ?   85.97%           
===============================================
  Files                   ?      231           
  Lines                   ?    18502           
  Branches                ?        0           
===============================================
  Hits                    ?    15907           
  Misses                  ?     2595           
  Partials                ?        0
Flag Coverage Δ
dask 47.32% <0.00%> (?)
non-dask 78.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86a613...e6a62ee. Read the comment docs.

v21.10 Release automation moved this from PR-Needs review to PR-Reviewer approved Sep 7, 2021
@dantegd
Copy link
Member

dantegd commented Sep 7, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit af13174 into rapidsai:branch-21.10 Sep 7, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Sep 7, 2021
@lowener lowener deleted the fix_log_dask branch September 7, 2021 15:44
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Fix log level for dask tree_reduce (rapidsai#4163)
ec5a0bf 
Closes rapidsai#4153.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cuML MNMG TfidfTransformer is printing a lot of unnecessary logs
3 participants
@lowener @codecov-commenter @dantegd