Update with rapids cmake new features #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #4175 +/- ##
===============================================
Coverage ? 85.96%
===============================================
Files ? 232
Lines ? 18503
Branches ? 0
===============================================
Hits ? 15907
Misses ? 2596
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dantegd
approved these changes
Aug 25, 2021
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This combines some general CMake style cleanup and brings new rapids-cmake features to cuml including: - Usage of `rapids_cmake_write_version_file` to simplify cuml version header writing - Usage of `rapids_cmake_install_lib_dir` to make sure we install raft correctly on non-debain based distro's ( lib64 ), while also handling conda installation requirements ( always lib no matter the distro ) - Usage of `rapids_cpm` pre-configured pacakges - Removal of early termination before `rapids_cpm_find` since a better solution now exists ( rapidsai/rapids-cmake#49 ) - Updates the examples to use `find_package(cuml)` since that is best practice. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines some general CMake style cleanup and brings new rapids-cmake features to cuml including:
rapids_cmake_write_version_fileto simplify cuml version header writingrapids_cmake_install_lib_dirto make sure we install raft correctly on non-debain based distro's ( lib64 ), while also handling conda installation requirements ( always lib no matter the distro )rapids_cpmpre-configured pacakgesrapids_cpm_findsince a better solution now exists ( [BUG]rapids_cpm_findisn't as invariant as one would expect rapids-cmake#49 )find_package(cuml)since that is best practice.