Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Refactor kmeans sampling code #4190

Merged
merged 3 commits into from
Sep 14, 2021
Merged

[REVIEW] Refactor kmeans sampling code #4190

merged 3 commits into from
Sep 14, 2021

Conversation

Nanthini10
Copy link
Contributor

Simplify the type check

@Nanthini10 Nanthini10 requested a review from a team as a code owner September 3, 2021 17:33
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 3, 2021
@Nanthini10 Nanthini10 added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 3, 2021
@caryr35 caryr35 added this to PR-WIP in v21.10 Release via automation Sep 7, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v21.10 Release Sep 7, 2021
dantegd
dantegd requested changes Sep 7, 2021
View reviewed changes
python/cuml/explainer/sampling.py Outdated Show resolved Hide resolved
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Sep 7, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@0e770fa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #4190   +/-   ##
===============================================
  Coverage                ?   85.97%           
===============================================
  Files                   ?      231           
  Lines                   ?    18499           
  Branches                ?        0           
===============================================
  Hits                    ?    15905           
  Misses                  ?     2594           
  Partials                ?        0
Flag Coverage Δ
dask 46.72% <0.00%> (?)
non-dask 78.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e770fa...7450d92. Read the comment docs.

@Nanthini10 Nanthini10 added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Sep 9, 2021
v21.10 Release automation moved this from PR-Needs review to PR-Reviewer approved Sep 14, 2021
@dantegd
Copy link
Member

dantegd commented Sep 14, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 864a12a into rapidsai:branch-21.10 Sep 14, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Sep 14, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@Nanthini10
Refactor kmeans sampling code (rapidsai#4190)
88add9d 
Simplify the type check

Authors:
  - Nanthini (https://github.com/Nanthini10)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nanthini10 @codecov-commenter @dantegd