Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thrust_create_target to install export in CMakeLists #4209

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Sep 14, 2021

This will avoid from consumers having to add Thrust explicitly when consuming cuML in CMake.

cc @shaneding

@dantegd dantegd added bug Something isn't working 3 - Ready for Review Ready for review by team Build or Dep Issues related to building the code or dependencies non-breaking Non-breaking change labels Sep 14, 2021
@dantegd dantegd requested a review from a team as a code owner September 14, 2021 23:09
@dantegd dantegd added this to PR-WIP in v21.10 Release via automation Sep 14, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@3a987fe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #4209   +/-   ##
===============================================
  Coverage                ?   86.08%           
===============================================
  Files                   ?      231           
  Lines                   ?    18637           
  Branches                ?        0           
===============================================
  Hits                    ?    16043           
  Misses                  ?     2594           
  Partials                ?        0           
Flag Coverage Δ
dask 47.05% <0.00%> (?)
non-dask 78.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a987fe...e3fbcee. Read the comment docs.

v21.10 Release automation moved this from PR-WIP to PR-Reviewer approved Sep 15, 2021
@dantegd
Copy link
Member Author

dantegd commented Sep 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d2d4e29 into rapidsai:branch-21.10 Sep 15, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Sep 15, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This will avoid from consumers having to add Thrust explicitly when consuming cuML in CMake. 

cc @shaneding

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: rapidsai#4209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Build or Dep Issues related to building the code or dependencies CMake CUDA/C++ non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants