Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental option to build libcuml++ only with FIL #4225

Merged
merged 6 commits into from
Sep 30, 2021
Merged

Experimental option to build libcuml++ only with FIL #4225

merged 6 commits into from
Sep 30, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Sep 22, 2021

@dantegd dantegd added 2 - In Progress Currenty a work in progress feature request New feature or request non-breaking Non-breaking change labels Sep 22, 2021
wphicks
wphicks reviewed Sep 22, 2021
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@caryr35 caryr35 added this to PR-WIP in v21.10 Release via automation Sep 22, 2021
@dantegd
Copy link
Member Author

dantegd commented Sep 23, 2021

rerun tests

@dantegd dantegd marked this pull request as ready for review September 23, 2021 17:19
@dantegd dantegd requested a review from a team as a code owner September 23, 2021 17:19
@dantegd dantegd added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Sep 23, 2021
@wphicks
Copy link
Contributor

wphicks commented Sep 27, 2021

Could we also suppress the get_faiss.cmake call when we're not making use of FAISS? Just noticed while working on the FIL backend that as it stands, downstream consumers need BLAS in their build environment because it's required by FAISS.

wphicks
wphicks approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and now actively using it in Triton-FIL. Good to go as far as I'm concerned!

@dantegd
Copy link
Member Author

dantegd commented Sep 27, 2021

rerun tests

v21.10 Release automation moved this from PR-WIP to PR-Reviewer approved Sep 27, 2021
cjnolet
cjnolet approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dantegd
Copy link
Member Author

dantegd commented Sep 30, 2021

rerun tests

2 similar comments
@dantegd
Copy link
Member Author

dantegd commented Sep 30, 2021

rerun tests

@dantegd
Copy link
Member Author

dantegd commented Sep 30, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@8cc833f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #4225   +/-   ##
===============================================
  Coverage                ?   86.19%           
===============================================
  Files                   ?      231           
  Lines                   ?    18837           
  Branches                ?        0           
===============================================
  Hits                    ?    16236           
  Misses                  ?     2601           
  Partials                ?        0
Flag Coverage Δ
dask 47.06% <0.00%> (?)
non-dask 78.94% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc833f...faee10e. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Sep 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 835a9ae into rapidsai:branch-21.10 Sep 30, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Sep 30, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Experimental option to build libcuml++ only with FIL (rapidsai#4225)
3dbdcea 
cc @wphicks

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CMake CUDA/C++ feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v21.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dantegd @wphicks @codecov-commenter @cjnolet