Fea/umap refine #4228
Fea/umap refine #4228
Conversation
trxcllnt
added
3 - Ready for Review
There was a problem hiding this comment.
I like this design because it allows us to compute the connectivities graph individually from the embedding. We've been also talking about exposing a function like get_graph through the Python layer because, for example, other libraries such as Scanpy call fuzzy_simplicial_set on the UMAP estimator directly.
Overall, the changes are great and very straightforward. Just a couple very minor things.
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
|
@AjayThorve @trxcllnt PR #4217 needs to get merged for CI to pass, so I canceled the job, will re-trigger once that's in |
Sounds good, thanks! |
|
rerun tests |
|
@gpucibot merge |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #4228 +/- ##
===============================================
Coverage ? 86.19%
===============================================
Files ? 231
Lines ? 18837
Branches ? 0
===============================================
Hits ? 16236
Misses ? 2601
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This PR aims to add UMAP refine function, to facilitate iterative fitting without using `callbacks`, which makes it possible to run UMAP in the node-rapids bindings and show iterative training visualizations. Related node-cuml PR [here](rapidsai/node#293). - adds UMAP refine & get_graph (to only calculate the cgraph computed in UMAP::fit once). cc @trxcllnt , @exactlyallan Authors: - Ajay Thorve (https://github.com/AjayThorve) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4228
This PR aims to add UMAP refine function, to facilitate iterative fitting without using
callbacks, which makes it possible to run UMAP in the node-rapids bindings and show iterative training visualizations. Related node-cuml PR here.cc @trxcllnt , @exactlyallan