Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an explicit excpetion if the input array is empty in DBSCAN.fit #4273 #4275

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Throw an explicit excpetion if the input array is empty in DBSCAN.fit #4273 #4275

merged 3 commits into from
Oct 13, 2021

Conversation

viktorkovesd
Copy link
Contributor

@viktorkovesd viktorkovesd commented Oct 10, 2021 •
edited

Closes #4273

@viktorkovesd viktorkovesd requested review from a team as code owners October 10, 2021 11:47
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Oct 10, 2021
@viktorkovesd viktorkovesd changed the title Throw an explicit excpetion if the input array is empty in DBSCAN.fit Throw an explicit excpetion if the input array is empty in DBSCAN.fit #4273 Oct 10, 2021
@dantegd
Copy link
Member

dantegd commented Oct 11, 2021

ok to test

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Oct 11, 2021
dantegd
dantegd requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just had a comment about using assert instead (and don't trust my code formatting), but otherwise looks great!

cpp/src/dbscan/dbscan.cuh Outdated Show resolved Hide resolved
cpp/src/dbscan/dbscan.cuh Outdated Show resolved Hide resolved
cjnolet
cjnolet requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized i reviewed this and didn't submit it.

cjnolet
cjnolet approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@51c41c4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4275   +/-   ##
===============================================
  Coverage                ?   86.07%           
===============================================
  Files                   ?      231           
  Lines                   ?    18697           
  Branches                ?        0           
===============================================
  Hits                    ?    16093           
  Misses                  ?     2604           
  Partials                ?        0
Flag Coverage Δ
dask 47.02% <0.00%> (?)
non-dask 78.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c41c4...30ae67e. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Oct 13, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 892a688 into rapidsai:branch-21.12 Oct 13, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viktorkovesd
Throw an explicit excpetion if the input array is empty in DBSCAN.fit r…
b3800d6 
…apidsai#4273 (rapidsai#4275)

Closes rapidsai#4273

Authors:
  - https://github.com/viktorkovesd

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]DBSCAN.fit on empty array raise floating point exception and terminate python
5 participants
@viktorkovesd @GPUtester @dantegd @codecov-commenter @cjnolet