Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Categorical Naive Bayes sparse handling #4277

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Fix for Categorical Naive Bayes sparse handling #4277

merged 3 commits into from
Oct 12, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Oct 11, 2021

No description provided.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 11, 2021
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Oct 11, 2021
@dantegd dantegd added this to PR-WIP in v21.12 Release via automation Oct 11, 2021
v21.12 Release automation moved this from PR-WIP to PR-Reviewer approved Oct 11, 2021
@dantegd
Copy link
Member

dantegd commented Oct 11, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@cbc691f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4277   +/-   ##
===============================================
  Coverage                ?   86.06%           
===============================================
  Files                   ?      231           
  Lines                   ?    18692           
  Branches                ?        0           
===============================================
  Hits                    ?    16088           
  Misses                  ?     2604           
  Partials                ?        0
Flag Coverage Δ
dask 47.01% <0.00%> (?)
non-dask 78.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc691f...1036f3d. Read the comment docs.

@lowener lowener marked this pull request as ready for review October 12, 2021 10:40
@lowener lowener requested a review from a team as a code owner October 12, 2021 10:40
@rapids-bot rapids-bot bot merged commit dd7cbf4 into rapidsai:branch-21.12 Oct 12, 2021
v21.12 Release automation moved this from PR-Reviewer approved to Done Oct 12, 2021
@dantegd
Copy link
Member

dantegd commented Oct 12, 2021

@gpucibot merge

@lowener lowener deleted the 21.12-nb-fix branch October 12, 2021 15:34
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Fix for Categorical Naive Bayes sparse handling (rapidsai#4277)
9168938 
Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
v21.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lowener @dantegd @codecov-commenter