Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] RAFT distance prims public API update #4280

Merged
merged 15 commits into from
Oct 22, 2021
Merged

[REVIEW] RAFT distance prims public API update #4280

merged 15 commits into from
Oct 22, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Oct 12, 2021

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 12, 2021
@cjnolet cjnolet requested a review from a team as a code owner October 12, 2021 15:43
@cjnolet cjnolet changed the title [DONT MERGE] Testing raft branch [DONT MERGE] Testing raft branch for distance primitives public API update Oct 12, 2021
@cjnolet cjnolet requested a review from a team as a code owner October 12, 2021 17:06
@cjnolet cjnolet changed the title [DONT MERGE] Testing raft branch for distance primitives public API update [WIP] RAFT distance prims public API update Oct 12, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Oct 12, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Oct 12, 2021

Not sure if this is a cache issue but I can't seem to reproduce this error locally

@cjnolet
Copy link
Member Author

cjnolet commented Oct 12, 2021

rerun tests

@caryr35 caryr35 added this to PR-WIP in v21.12 Release via automation Oct 13, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v21.12 Release Oct 13, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Oct 13, 2021

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Oct 13, 2021

rerun tests

@cjnolet cjnolet changed the title [WIP] RAFT distance prims public API update [REVIEW] RAFT distance prims public API update Oct 14, 2021
divyegala
divyegala approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
cpp/test/CMakeLists.txt Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@dd7cbf4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4280   +/-   ##
===============================================
  Coverage                ?   86.00%           
===============================================
  Files                   ?      231           
  Lines                   ?    18577           
  Branches                ?        0           
===============================================
  Hits                    ?    15978           
  Misses                  ?     2599           
  Partials                ?        0
Flag Coverage Δ
dask 46.67% <0.00%> (?)
non-dask 78.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7cbf4...342f193. Read the comment docs.

v21.12 Release automation moved this from PR-Needs review to PR-Reviewer approved Oct 22, 2021
@dantegd
Copy link
Member

dantegd commented Oct 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ee2e863 into rapidsai:branch-21.12 Oct 22, 2021
v21.12 Release automation moved this from PR-Reviewer approved to Done Oct 22, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
RAFT distance prims public API update (rapidsai#4280)
fea7cdc 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjnolet @codecov-commenter @dantegd @divyegala