Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mean_squared_error #4287

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

viclafargue
Copy link
Contributor

Closes #4281

The bug happens when providing a vector and a 1D array as inputs to the mean_squared_error function (see #4281).

@viclafargue viclafargue requested a review from a team as a code owner October 14, 2021 15:17
@viclafargue viclafargue added bug Something isn't working non-breaking Non-breaking change labels Oct 14, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 14, 2021
python/cuml/metrics/regression.pyx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@892a688). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4287   +/-   ##
===============================================
  Coverage                ?   86.07%           
===============================================
  Files                   ?      231           
  Lines                   ?    18699           
  Branches                ?        0           
===============================================
  Hits                    ?    16095           
  Misses                  ?     2604           
  Partials                ?        0           
Flag Coverage Δ
dask 47.01% <0.00%> (?)
non-dask 78.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892a688...5dc9dc9. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Oct 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4f93999 into rapidsai:branch-21.12 Oct 15, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Closes rapidsai#4281

The bug happens when providing a vector and a 1D array as inputs to the `mean_squared_error` function (see rapidsai#4281).

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cuml.metrics.regression gives wrong output when shape of y_true and y_pred are not same
3 participants