Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounting for RAFT updates to matrix, stats, and random implementations in detail #4294

Merged
merged 16 commits into from
Nov 12, 2021
Merged

Accounting for RAFT updates to matrix, stats, and random implementations in detail #4294

merged 16 commits into from
Nov 12, 2021

Conversation

divyegala
Copy link
Member

Depends on rapidsai/raft#356

@divyegala divyegala added 3 - Ready for Review Ready for review by team CUDA / C++ CUDA issue 5 - Merge After Dependencies Depends on another PR: do not merge out of order improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 19, 2021
@divyegala divyegala requested review from a team as code owners October 19, 2021 21:44
@caryr35 caryr35 added this to PR-WIP in v21.12 Release via automation Oct 20, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v21.12 Release Oct 20, 2021
cjnolet
cjnolet approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a few more places that need header name changes but otherwise LGTM. Pre-approving.

v21.12 Release automation moved this from PR-Needs review to PR-Reviewer approved Oct 25, 2021
v21.12 Release automation moved this from PR-Reviewer approved to PR-Needs review Nov 3, 2021
@github-actions github-actions bot added the gpuCI gpuCI issue label Nov 3, 2021
@divyegala divyegala requested a review from a team as a code owner November 3, 2021 21:45
@github-actions github-actions bot added the conda conda issue label Nov 3, 2021
@divyegala
Copy link
Member Author

rerun tests

1 similar comment
@jjacobelli
Copy link
Contributor

rerun tests

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 11, 2021
@divyegala divyegala requested a review from a team as a code owner November 12, 2021 02:08
@github-actions github-actions bot removed the conda conda issue label Nov 12, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@34f7929). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4294   +/-   ##
===============================================
  Coverage                ?   85.99%           
===============================================
  Files                   ?      231           
  Lines                   ?    18712           
  Branches                ?        0           
===============================================
  Hits                    ?    16092           
  Misses                  ?     2620           
  Partials                ?        0
Flag Coverage Δ
dask 46.97% <0.00%> (?)
non-dask 78.68% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f7929...17a25b4. Read the comment docs.

v21.12 Release automation moved this from PR-Needs review to PR-Reviewer approved Nov 12, 2021
@dantegd
Copy link
Member

dantegd commented Nov 12, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 05d7e37 into rapidsai:branch-21.12 Nov 12, 2021
v21.12 Release automation moved this from PR-Reviewer approved to Done Nov 12, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@divyegala
Accounting for RAFT updates to matrix, stats, and random implementati…
9e23356 
…ons in detail (rapidsai#4294)

Depends on rapidsai/raft#356

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: rapidsai#4294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@cjnolet cjnolet cjnolet approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 5 - Merge After Dependencies Depends on another PR: do not merge out of order CMake CUDA / C++ CUDA issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@divyegala @jjacobelli @codecov-commenter @dantegd @cjnolet