Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split C++ tests into separate binaries #4295

Merged
merged 14 commits into from
Feb 18, 2022

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Oct 19, 2021

Closes #4104

@dantegd dantegd added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 19, 2021
@dantegd dantegd added this to PR-WIP in v21.12 Release via automation Oct 19, 2021
@dantegd dantegd removed this from PR-WIP in v21.12 Release Nov 12, 2021
@dantegd dantegd added this to PR-WIP in v22.02 Release via automation Nov 12, 2021
@dantegd dantegd changed the base branch from branch-21.12 to branch-22.02 November 12, 2021 13:27
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@dantegd dantegd removed this from PR-WIP in v22.02 Release Jan 24, 2022
@dantegd dantegd added this to PR-WIP in v22.04 Release via automation Jan 24, 2022
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue gpuCI gpuCI issue labels Feb 7, 2022
@dantegd dantegd changed the base branch from branch-22.02 to branch-22.04 February 7, 2022 18:12
@github-actions github-actions bot removed gpuCI gpuCI issue Cython / Python Cython or Python issue conda conda issue labels Feb 11, 2022
@dantegd dantegd changed the title Split C++ tests into separate binaries [skip-ci] Split C++ tests into separate binaries Feb 11, 2022
@github-actions github-actions bot added the gpuCI gpuCI issue label Feb 11, 2022
@dantegd
Copy link
Member Author

dantegd commented Feb 15, 2022

rerun tests

@dantegd
Copy link
Member Author

dantegd commented Feb 16, 2022

rerun tests

@dantegd dantegd marked this pull request as ready for review February 16, 2022 22:31
@dantegd dantegd requested review from a team as code owners February 16, 2022 22:31
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

test_name=$(basename $gt)
echo "Patching gtest $test_name"
chrpath -d ${gt}
patchelf --replace-needed `patchelf --print-needed ${gt} | grep faiss` libfaiss.so ${gt}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but why do we need to do this?

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 17, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@88e41e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4295   +/-   ##
===============================================
  Coverage                ?   83.88%           
===============================================
  Files                   ?      250           
  Lines                   ?    20052           
  Branches                ?        0           
===============================================
  Hits                    ?    16820           
  Misses                  ?     3232           
  Partials                ?        0           
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e41e8...73ce560. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Feb 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cbe4beb into rapidsai:branch-22.04 Feb 18, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 18, 2022
rapids-bot bot pushed a commit that referenced this pull request Feb 24, 2022
Depends on #4295 

PR allows `libcuml++` to be built with individual algorithms, or individual families of algorithms with the argument `CUML_ALGORITHMS`. It defaults to `ALL`, and can take multiple options like:

```
cmake .. -DCUML_ALGORITHMS="FIL;TREESHAP"
```

which will build a `libcuml++` only containing FIL and GPUTreeSHAP components. 

PR to update build documentation will follow up.

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #4296
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Depends on rapidsai#4295 

PR allows `libcuml++` to be built with individual algorithms, or individual families of algorithms with the argument `CUML_ALGORITHMS`. It defaults to `ALL`, and can take multiple options like:

```
cmake .. -DCUML_ALGORITHMS="FIL;TREESHAP"
```

which will build a `libcuml++` only containing FIL and GPUTreeSHAP components. 

PR to update build documentation will follow up.

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress CMake CUDA/C++ gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[FEA] Split C++ tests into separate binaries
5 participants