Enable training single GPU cuML models using Dask DataFrames and Series #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for dask_cudf objects
dantegd
requested changes
Oct 21, 2021
|
rerun tests |
1 similar comment
|
rerun tests |
dantegd
requested changes
Nov 9, 2021
| @@ -556,8 +563,12 @@ def convert_dtype(X, | |||
| if the conversion would lose information. | |||
| """ | |||
|
|
|||
| if isinstance(X, (dask_cudf.core.Series, dask_cudf.core.DataFrame)): | |||
| # TODO: Warn, but not when using dask_sql | |||
There was a problem hiding this comment.
Can you open a github issue to track this?
dantegd
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4300 +/- ##
===============================================
Coverage ? 86.01%
===============================================
Files ? 231
Lines ? 18771
Branches ? 0
===============================================
Hits ? 16146
Misses ? 2625
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
dantegd
approved these changes
Nov 15, 2021
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…es (rapidsai#4300) This PR makes it possible to train single GPU cuML models using Dask DataFrames and Series by converting the Dask data-structures to their cudf counterparts before training. This will allow using Dask-SQL with cuML models. Tests added for logistic regression, currently working on adding more Depends on rapidsai#4317 Authors: - https://github.com/ChrisJar - Sarah Yurick (https://github.com/sarahyurick) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to train single GPU cuML models using Dask DataFrames and Series by converting the Dask data-structures to their cudf counterparts before training. This will allow using Dask-SQL with cuML models.
Tests added for logistic regression, currently working on adding more
Depends on #4317