Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Using sparse expanded distances where possible #4310

Merged
merged 1 commit into from
Oct 27, 2021
Merged

[REVIEW] Using sparse expanded distances where possible #4310

merged 1 commit into from
Oct 27, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Oct 27, 2021

No description provided.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Oct 27, 2021
@cjnolet cjnolet requested a review from a team as a code owner October 27, 2021 16:30
@cjnolet cjnolet added this to PR-WIP in v21.12 Release via automation Oct 27, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 27, 2021
v21.12 Release automation moved this from PR-WIP to PR-Reviewer approved Oct 27, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@92a40e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4310   +/-   ##
===============================================
  Coverage                ?   86.06%           
===============================================
  Files                   ?      231           
  Lines                   ?    18702           
  Branches                ?        0           
===============================================
  Hits                    ?    16095           
  Misses                  ?     2607           
  Partials                ?        0
Flag Coverage Δ
dask 47.00% <0.00%> (?)
non-dask 78.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a40e0...d2de1a7. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Oct 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit effa6cd into rapidsai:branch-21.12 Oct 27, 2021
v21.12 Release automation moved this from PR-Reviewer approved to Done Oct 27, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Using sparse expanded distances where possible (rapidsai#4310)
9f42640 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
v21.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjnolet @codecov-commenter @dantegd