Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GLM typo on device/host pointer [skip-ci] #4320

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix GLM typo on device/host pointer [skip-ci] #4320

merged 1 commit into from
Nov 4, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Nov 1, 2021

Closes #4304

@lowener lowener requested a review from a team as a code owner November 1, 2021 13:18
@lowener lowener mentioned this pull request Nov 1, 2021
Closed
@lowener lowener added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Nov 1, 2021
@dantegd
Copy link
Member

dantegd commented Nov 2, 2021

rerun tests

@lowener lowener changed the title Fix GML typo on device/host pointer Fix GLM typo on device/host pointer Nov 2, 2021
@dantegd
Copy link
Member

dantegd commented Nov 4, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Nov 4, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@42303fb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4320   +/-   ##
===============================================
  Coverage                ?   86.03%           
===============================================
  Files                   ?      231           
  Lines                   ?    18717           
  Branches                ?        0           
===============================================
  Hits                    ?    16103           
  Misses                  ?     2614           
  Partials                ?        0
Flag Coverage Δ
dask 46.99% <0.00%> (?)
non-dask 78.72% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42303fb...8d902fc. Read the comment docs.

@dantegd dantegd changed the title Fix GLM typo on device/host pointer Fix GLM typo on device/host pointer [skip-ci] Nov 4, 2021
@dantegd
Copy link
Member

dantegd commented Nov 4, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit 5c46b61 into rapidsai:branch-21.12 Nov 4, 2021
@lowener lowener deleted the 21.12-typo-glm branch November 4, 2021 15:47
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Fix GLM typo on device/host pointer (rapidsai#4320)
60a3151 
Closes rapidsai#4304

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CUDA/C++ doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Possible non-trivial typo in cpp/include/cuml/linear_model/glm.hpp
3 participants
@lowener @dantegd @codecov-commenter