[ENH] Ability to pass fp64 type to cuml benchmarks #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teju85
added
improvement
dantegd
approved these changes
Nov 3, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4323 +/- ##
===============================================
Coverage ? 86.03%
===============================================
Files ? 231
Lines ? 18717
Branches ? 0
===============================================
Hits ? 16103
Misses ? 2614
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This is based on the @dantegd 's branch [here](https://github.com/dantegd/cuml/tree/2112-dbg-float64-bench), along with adding a commandline option to choose between fp64 and fp32 types. Default stays fp32. @dantegd can you please review? Authors: - Thejaswi. N. S (https://github.com/teju85) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the @dantegd 's branch here, along with adding a commandline option to choose between fp64 and fp32 types. Default stays fp32.
@dantegd can you please review?