Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compute-sanitizer instead of cuda-memcheck [skip-ci] #4324

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

teju85
Copy link
Member

@teju85 teju85 commented Nov 2, 2021

@dantegd this is a short PR to update the memcheck/sanitizer python wrapper script. It drops cuda-memcheck in favor of the latest compute-sanitizer tool from CUDA SDK.

@teju85 teju85 requested a review from a team as a code owner November 2, 2021 13:18
@teju85 teju85 added Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed CUDA/C++ labels Nov 2, 2021
@dantegd
Copy link
Member

dantegd commented Nov 4, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Nov 4, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@42303fb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4324   +/-   ##
===============================================
  Coverage                ?   85.96%           
===============================================
  Files                   ?      231           
  Lines                   ?    18592           
  Branches                ?        0           
===============================================
  Hits                    ?    15982           
  Misses                  ?     2610           
  Partials                ?        0           
Flag Coverage Δ
dask 46.66% <0.00%> (?)
non-dask 78.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42303fb...f286936. Read the comment docs.

@dantegd dantegd changed the title Use compute-sanitizer instead of cuda-memcheck Use compute-sanitizer instead of cuda-memcheck [skip-ci] Nov 4, 2021
@dantegd
Copy link
Member

dantegd commented Nov 4, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit ac33c34 into rapidsai:branch-21.12 Nov 4, 2021
@teju85 teju85 deleted the enh-ext-memcheck-wrapper branch November 12, 2021 10:22
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd this is a short PR to update the memcheck/sanitizer python wrapper script. It drops cuda-memcheck in favor of the latest compute-sanitizer tool from CUDA SDK.

Authors:
  - Thejaswi. N. S (https://github.com/teju85)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants