Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable rmm devicebuffer in array.py #4333

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Temporarily disable rmm devicebuffer in array.py #4333

merged 1 commit into from
Nov 8, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Nov 8, 2021

Temporary fix for #4332

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Nov 8, 2021
@dantegd dantegd requested a review from a team as a code owner November 8, 2021 18:43
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 8, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@ac33c34). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4333   +/-   ##
===============================================
  Coverage                ?   85.99%           
===============================================
  Files                   ?      231           
  Lines                   ?    18712           
  Branches                ?        0           
===============================================
  Hits                    ?    16092           
  Misses                  ?     2620           
  Partials                ?        0
Flag Coverage Δ
dask 46.97% <0.00%> (?)
non-dask 78.68% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac33c34...0363ee0. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Nov 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 15b569d into rapidsai:branch-21.12 Nov 8, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Temporarily disable rmm devicebuffer in array.py (rapidsai#4333)
8ef19f4 
Temporary fix for rapidsai#4332

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - John Zedlewski (https://github.com/JohnZed)

URL: rapidsai#4333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dantegd @codecov-commenter @JohnZed @wphicks