Update clang-format version in docs; allow unanchored version string #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clang-format -version` installed with apt on Ubuntu reports `Ubuntu clang-format version 11.0.0-2~ubuntu20.04.1`, so we need an unanchored search here. The script also requires 11.0.0 and not 8.0.1 now.
cjnolet
added
improvement
dantegd
approved these changes
Nov 15, 2021
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4365 +/- ##
===============================================
Coverage ? 86.03%
===============================================
Files ? 231
Lines ? 18751
Branches ? 0
===============================================
Hits ? 16132
Misses ? 2619
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…apidsai#4365) `clang-format -version` installed with apt on Ubuntu reports `Ubuntu clang-format version 11.0.0-2~ubuntu20.04.1`, so we need an unanchored search here. The script also requires 11.0.0 and not 8.0.1 now. Authors: - Zach Bjornson (https://github.com/zbjornson) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -versioninstalled with apt on Ubuntu reportsUbuntu clang-format version 11.0.0-2~ubuntu20.04.1, so we need an unanchored search here.The script also requires 11.0.0 and not 8.0.1 now.