Restore FIL convention of inlining code #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
approved these changes
Nov 16, 2021
canonizer
approved these changes
Nov 16, 2021
levsnv
added
Perf
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4366 +/- ##
===============================================
Coverage ? 86.01%
===============================================
Files ? 231
Lines ? 18771
Branches ? 0
===============================================
Hits ? 16146
Misses ? 2625
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
A previous PR has accidentally uninlined two methods. We are not aware of a significant perf impact in one or another direction, but the intention was to explore the instruction-level impact more before mainlining the change. Authors: - Levs Dolgovs (https://github.com/levsnv) Approvers: - William Hicks (https://github.com/wphicks) - Andy Adinets (https://github.com/canonizer) URL: rapidsai#4366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR has accidentally uninlined two methods. We are not aware of a significant perf impact in one or another direction, but the intention was to explore the instruction-level impact more before mainlining the change.