Add a warning to prefer LinearSVM over SVM(kernel='linear') #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achirkin
added
3 - Ready for Review
|
NB: need to check if the warning is not disturbingly printed many times in case of multiclass training / parameter search. |
achirkin
added
2 - In Progress
achirkin
added
3 - Ready for Review
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #4382 +/- ##
===============================================
Coverage ? 85.73%
===============================================
Files ? 236
Lines ? 19314
Branches ? 0
===============================================
Hits ? 16558
Misses ? 2756
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
dantegd
approved these changes
Dec 4, 2021
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…#4382) Suggest using LinearSVM when the user chooses to use the linear kernel in SVM. The reason is that LinearSVM uses a specialized faster solver. Closes rapidsai#1664 Also partially addresses rapidsai#2857 Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest using LinearSVM when the user chooses to use the linear kernel in SVM. The reason is that LinearSVM uses a specialized faster solver.
Closes #1664
Also partially addresses #2857