[REVIEW] Refactor DBSCAN to use ml-prims. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
changed the title
|
I tagged it as in progress while we look into the scalability issue, I’ll also try running your branch on Monday :) |
|
Sure, I've incorporated the latest changes to the ml-prims code, including the new distance API. Also removed unused code and merged the separate dbscan run paths for the Python & Googletests API. |
cjnolet
force-pushed
the
consolidate-ml-prims
branch
from
4bf0b15
to
c5c3d99
Compare
…ad of compiling when cythonizing
…meantime. This way the other cleanup can be merged while we work on the bug in algo6
…using resutls that differed slightly from sklearn
Conflicts: .gitignore CHANGELOG.md Dockerfile README.md cuML/CMakeLists.txt docs/source/conf.py
cjnolet
changed the title
|
This is ready to be reviewed & merged. |
cjnolet
added
3 - Ready for Review
|
This PR means that PR #47 is no longer needed and we can just close it, right? |
|
Correct.
…Sent from my iPhone
On Dec 18, 2018, at 9:16 PM, Dante Gama Dessavre ***@***.***> wrote:
This PR means that PR #47 is no longer needed and we can just close it, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
dantegd
approved these changes
Dec 21, 2018
dantegd
pushed a commit
that referenced
this pull request
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request encompasses a very large body of work and I have squashed the commits to make it easier for the reviewers.
The tests all pass, however, the DBSCAN Jupyter notebook seems to indicate there is a bug that could be causing a scalability issue.
The following error prints when I attempt to run the cuml DBSCAN training on 1000 rows of the mortgage dataset: