Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe Index as columns in ColumnTransformer #4481

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Dataframe Index as columns in ColumnTransformer #4481

merged 2 commits into from
Jan 18, 2022

Conversation

viclafargue
Copy link
Contributor

Answers #4435

@viclafargue viclafargue requested a review from a team as a code owner January 12, 2022 18:47
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 12, 2022
@viclafargue viclafargue mentioned this pull request Jan 12, 2022
Closed
@dantegd
Copy link
Member

dantegd commented Jan 13, 2022

rerun tests

dantegd
dantegd requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one very small request

python/cuml/_thirdparty/sklearn/preprocessing/_column_transformer.py Outdated Show resolved Hide resolved
@dantegd dantegd added non-breaking Non-breaking change bug Something isn't working labels Jan 13, 2022
@dantegd
Copy link
Member

dantegd commented Jan 13, 2022

@gpucibot merge

@dantegd
Copy link
Member

dantegd commented Jan 17, 2022

rerun tests

@rapids-bot rapids-bot bot merged commit 592834c into rapidsai:branch-22.02 Jan 18, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@f5556ba). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4481   +/-   ##
===============================================
  Coverage                ?   85.77%           
===============================================
  Files                   ?      236           
  Lines                   ?    19314           
  Branches                ?        0           
===============================================
  Hits                    ?    16567           
  Misses                  ?     2747           
  Partials                ?        0
Flag Coverage Δ
dask 46.54% <0.00%> (?)
non-dask 78.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5556ba...de5c4e6. Read the comment docs.

vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Dataframe Index as columns in ColumnTransformer (rapidsai#4481)
71f50a0 
Answers rapidsai#4435

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viclafargue @dantegd @codecov-commenter