Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Target Encoder with variance statistics #4483

Merged
merged 27 commits into from
Feb 24, 2022
Merged

[REVIEW] Target Encoder with variance statistics #4483

merged 27 commits into from
Feb 24, 2022

Conversation

daxiongshu
Copy link
Contributor

This PR allows TargetEncoder to encode the variance of the target as requested by #4440

@daxiongshu
Merge pull request #15 from rapidsai/branch-0.15
cf87af4 
sync with upstream
@daxiongshu
Merge pull request #18 from rapidsai/branch-0.17
e3b7848 
sync with upstream
@daxiongshu
Merge pull request #19 from rapidsai/branch-0.17
e6d8ec3 
sync with upstream
@daxiongshu
Merge pull request #20 from rapidsai/branch-0.18
8b1b7c3 
Sync with upstream
@daxiongshu
Merge pull request #22 from rapidsai/branch-0.19
7a51c5a 
sync with upstream
@daxiongshu
Merge pull request #23 from rapidsai/branch-0.19
d7a2f60 
sync with upstream
@daxiongshu
Merge pull request #27 from rapidsai/branch-21.06
6366e9e 
merge with upstream
@daxiongshu
Merge branch 'rapidsai:branch-21.10' into branch-21.10
7757342
@daxiongshu
Merge pull request #32 from rapidsai/branch-22.02
6349067 
sync with upstream
@daxiongshu
Merge branch 'rapidsai:branch-22.02' into branch-22.02
6c408e5
@daxiongshu
basics of TE variance
15dbe12
@daxiongshu
fix typos
084f9a6
@daxiongshu
basic var test passed
f4212a5
@daxiongshu
fix flake8 style
f036a60
@daxiongshu daxiongshu requested a review from a team as a code owner January 13, 2022 16:20
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 13, 2022
@daxiongshu daxiongshu added 2 - In Progress Currenty a work in progress non-breaking Non-breaking change feature request New feature or request labels Jan 13, 2022
@daxiongshu daxiongshu mentioned this pull request Jan 13, 2022
Closed
@caryr35 caryr35 added this to PR-WIP in v22.02 Release via automation Jan 18, 2022
@daxiongshu
Copy link
Contributor Author

rerun test

@daxiongshu daxiongshu changed the base branch from branch-22.02 to branch-22.04 January 28, 2022 21:28
@dantegd dantegd removed this from PR-WIP in v22.02 Release Feb 3, 2022
@dantegd dantegd added this to PR-WIP in v22.04 Release via automation Feb 3, 2022
@daxiongshu
Copy link
Contributor Author

rerun test

@daxiongshu
Copy link
Contributor Author

rerun tests

@daxiongshu daxiongshu changed the title [WIP] Target Encoder with variance statistics [REVIEW] Target Encoder with variance statistics Feb 17, 2022
@daxiongshu daxiongshu added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 2 - In Progress Currenty a work in progress labels Feb 17, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@647f7cd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4483   +/-   ##
===============================================
  Coverage                ?   83.88%           
===============================================
  Files                   ?      250           
  Lines                   ?    20072           
  Branches                ?        0           
===============================================
  Hits                    ?    16837           
  Misses                  ?     3235           
  Partials                ?        0
Flag Coverage Δ
dask 45.13% <0.00%> (?)
non-dask 76.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647f7cd...0a36d29. Read the comment docs.

v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 24, 2022
@dantegd
Copy link
Member

dantegd commented Feb 24, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 388a928 into rapidsai:branch-22.04 Feb 24, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 24, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@daxiongshu
Target Encoder with variance statistics (rapidsai#4483)
7e42f2c 
This PR allows `TargetEncoder` to encode the `variance` of the target as requested by rapidsai#4440

Authors:
  - Jiwei Liu (https://github.com/daxiongshu)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daxiongshu @codecov-commenter @dantegd