Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Treelite to 2.2.1 #4484

Merged
merged 10 commits into from
Jan 25, 2022
Merged

Upgrade Treelite to 2.2.1 #4484

merged 10 commits into from
Jan 25, 2022

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jan 13, 2022 •
edited

The 2.2.0 version of Treelite incorporates the following major improvements:

In particular, dmlc/treelite#332, dmlc/treelite#330, dmlc/treelite#333 are required for #4447.

Requires rapidsai/integration#412.

EDIT. Using 2.2.1 patch release, to incorporate a hotfix (dmlc/treelite#340).

@hcho3 hcho3 requested review from a team as code owners January 13, 2022 17:08
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels Jan 13, 2022
@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 13, 2022
@hcho3 hcho3 added feature request New feature or request improvement Improvement / enhancement to an existing function and removed improvement Improvement / enhancement to an existing function feature request New feature or request labels Jan 13, 2022
@hcho3 hcho3 mentioned this pull request Jan 13, 2022
Merged
5 tasks
@hcho3 hcho3 mentioned this pull request Jan 13, 2022
Merged
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 13, 2022

rerun tests

2 similar comments
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 13, 2022

rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 14, 2022

rerun tests

@hcho3 hcho3 requested a review from a team as a code owner January 14, 2022 04:43
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 14, 2022
@hcho3 hcho3 changed the title Upgrade Treelite to 2.2.0 Upgrade Treelite to 2.2.1 Jan 15, 2022
@caryr35 caryr35 added this to PR-WIP in v22.02 Release via automation Jan 18, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.02 Release Jan 18, 2022
ajschmidt8
ajschmidt8 reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI has passed successfully with the new dependency version. I've just updated the branch in the integration PR below, so CI is re-running. Assuming that succeeds, we can merge it and then once those changes are propagated, we can rerun CI here one last time and then merge.

rapidsai/integration#412

ci/gpu/build.sh Outdated Show resolved Hide resolved
@hcho3 hcho3 mentioned this pull request Jan 21, 2022
Merged
2 tasks
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 24, 2022

Rerun tests

ajschmidt8
ajschmidt8 approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@b9e5537). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4484   +/-   ##
===============================================
  Coverage                ?   85.69%           
===============================================
  Files                   ?      236           
  Lines                   ?    19326           
  Branches                ?        0           
===============================================
  Hits                    ?    16562           
  Misses                  ?     2764           
  Partials                ?        0
Flag Coverage Δ
dask 46.52% <0.00%> (?)
non-dask 78.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e5537...18d6a6c. Read the comment docs.

v22.02 Release automation moved this from PR-Needs review to PR-Reviewer approved Jan 25, 2022
@dantegd
Copy link
Member

dantegd commented Jan 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 465e699 into rapidsai:branch-22.02 Jan 25, 2022
v22.02 Release automation moved this from PR-Reviewer approved to Done Jan 25, 2022
@hcho3 hcho3 deleted the upgrade_treelite branch January 25, 2022 20:09
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@hcho3
Upgrade Treelite to 2.2.1 (rapidsai#4484)
fdded85 
The 2.2.0 version of Treelite incorporates the following major improvements:

* dmlc/treelite#314
* dmlc/treelite#322, dmlc/treelite#327
* dmlc/treelite#325
* dmlc/treelite#332
* dmlc/treelite#330
* dmlc/treelite#333
* dmlc/treelite#334
* dmlc/treelite#304
* dmlc/treelite#335

In particular, dmlc/treelite#332, dmlc/treelite#330, dmlc/treelite#333 are required for rapidsai#4447.

Requires rapidsai/integration#412.

EDIT. Using 2.2.1 patch release, to incorporate a hotfix (dmlc/treelite#340).

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.02 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hcho3 @codecov-commenter @dantegd @ajschmidt8