Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CuPy 10 #4487

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Allow CuPy 10 #4487

merged 1 commit into from
Jan 14, 2022

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jan 14, 2022 •
edited

Relaxes version constraints to allow CuPy 10.

xref: rapidsai/integration#413

@jakirkham jakirkham requested a review from a team as a code owner January 14, 2022 03:07
@github-actions github-actions bot added the conda conda issue label Jan 14, 2022
@jakirkham jakirkham mentioned this pull request Jan 14, 2022
Merged
@jakirkham
Copy link
Member Author

Could use some help labeling this correctly 🙂

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@ead22e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4487   +/-   ##
===============================================
  Coverage                ?   85.75%           
===============================================
  Files                   ?      236           
  Lines                   ?    19310           
  Branches                ?        0           
===============================================
  Hits                    ?    16560           
  Misses                  ?     2750           
  Partials                ?        0
Flag Coverage Δ
dask 46.54% <0.00%> (?)
non-dask 78.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead22e0...d7f5c25. Read the comment docs.

@wphicks wphicks added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 14, 2022
@wphicks
Copy link
Contributor

wphicks commented Jan 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d0cbcd9 into rapidsai:branch-22.02 Jan 14, 2022
@jakirkham jakirkham deleted the allow_cupy_10 branch January 14, 2022 22:38
@jakirkham
Copy link
Member Author

Thanks William! 😀

vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@jakirkham
Allow CuPy 10 (rapidsai#4487)
df4c61a 
Relaxes version constraints to allow CuPy 10.

xref: rapidsai/integration#413

Authors:
  - https://github.com/jakirkham

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

Assignees
No one assigned
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jakirkham @codecov-commenter @wphicks @jjacobelli