Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pydoc and promote ColumnTransformer out of experimental #4509

Merged
merged 14 commits into from
May 23, 2022
Merged

Update pydoc and promote ColumnTransformer out of experimental #4509

merged 14 commits into from
May 23, 2022

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue requested a review from a team as a code owner January 24, 2022 10:11
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 24, 2022
dantegd
dantegd requested changes Jan 24, 2022
View reviewed changes
docs/source/api.rst Outdated Show resolved Hide resolved
@dantegd dantegd added doc Documentation non-breaking Non-breaking change labels Jan 24, 2022
@dantegd dantegd added this to PR-WIP in v22.04 Release via automation Jan 24, 2022
dantegd
dantegd requested changes Jan 24, 2022
View reviewed changes
python/cuml/compose/__init__.py Outdated
@@ -1,5 +1,5 @@
#
# Copyright (c) 2020-2021, NVIDIA CORPORATION.
# Copyright (c) 2022, NVIDIA CORPORATION.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright (c) 2022, NVIDIA CORPORATION.
# Copyright (c) 2020-2022, NVIDIA CORPORATION.

incorrect copyright header modification in the whole PR, please correct

v22.04 Release automation moved this from PR-WIP to PR-Needs review Jan 24, 2022
@lowener lowener mentioned this pull request Jan 28, 2022
Closed
lowener
lowener reviewed Jan 28, 2022
View reviewed changes
docs/source/api.rst Outdated Show resolved Hide resolved
@dantegd
Copy link
Member

dantegd commented Feb 3, 2022

rerun tests

@dantegd dantegd requested a review from lowener February 3, 2022 00:21
lowener
lowener approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dantegd
dantegd approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending CI

v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Mar 10, 2022
@dantegd dantegd self-assigned this Mar 10, 2022
@viclafargue
Copy link
Contributor Author

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 24, 2022

rerun tests

1 similar comment
@viclafargue
Copy link
Contributor Author

rerun tests

@caryr35 caryr35 added this to PR-WIP in v22.06 Release via automation Apr 12, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Reviewer approved in v22.06 Release Apr 12, 2022
@caryr35 caryr35 removed this from PR-Reviewer approved in v22.04 Release Apr 12, 2022
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@viclafargue viclafargue changed the base branch from branch-22.04 to branch-22.06 May 9, 2022 10:13
@viclafargue
Copy link
Contributor Author

rerun tests

@cjnolet
Copy link
Member

cjnolet commented May 23, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

Merging #4509 (a9dab3c) into branch-22.06 (15aba09) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06    #4509      +/-   ##
================================================
- Coverage         79.89%   79.87%   -0.03%     
================================================
  Files               180      180              
  Lines             11371    11379       +8     
================================================
+ Hits               9085     9089       +4     
- Misses             2286     2290       +4
Flag Coverage Δ
dask 45.50% <50.00%> (+0.04%) ⬆️
non-dask 69.50% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...party/sklearn/preprocessing/_column_transformer.py 74.75% <ø> (ø)
...hirdparty/sklearn/preprocessing/_discretization.py 83.33% <ø> (ø)
python/cuml/compose/__init__.py 100.00% <100.00%> (ø)
python/cuml/preprocessing/__init__.py 100.00% <100.00%> (ø)
python/cuml/neighbors/kernel_density.py 82.89% <0.00%> (-4.61%) ⬇️
python/cuml/internals/api_decorators.py 94.00% <0.00%> (+0.57%) ⬆️
python/cuml/preprocessing/LabelEncoder.py 93.24% <0.00%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15aba09...a9dab3c. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented May 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d9dd8ca into rapidsai:branch-22.06 May 23, 2022
v22.06 Release automation moved this from PR-Reviewer approved to Done May 23, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Update pydoc and promote ColumnTransformer out of experimental (rap…
cc68d90 
…idsai#4509)

- Promote `ColumnTransformer` out of experimental
- Add `ColumnTransformer` to documentation (answers to rapidsai#4418)
- Update preprocessing documentation

Authors:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@lowener lowener lowener approved these changes

Assignees

@dantegd dantegd

Labels
Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
No open projects
v22.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@viclafargue @dantegd @cjnolet @codecov-commenter @lowener