Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility of OneHotEncoder fit #4544

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Fix compatibility of OneHotEncoder fit #4544

merged 2 commits into from
Feb 3, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Feb 1, 2022

Fix #4426

@lowener lowener requested a review from a team as a code owner February 1, 2022 14:44
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 1, 2022
@lowener lowener changed the title Fix compatibility of onehot fit Fix compatibility of OneHotEncoder fit Feb 1, 2022
@lowener lowener added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Feb 1, 2022
@caryr35 caryr35 added this to PR-WIP in v22.04 Release via automation Feb 1, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.04 Release Feb 1, 2022
@dantegd
Copy link
Member

dantegd commented Feb 3, 2022

rerun tests

v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Feb 3, 2022
@dantegd
Copy link
Member

dantegd commented Feb 3, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@818bd25). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4544   +/-   ##
===============================================
  Coverage                ?   85.71%           
===============================================
  Files                   ?      236           
  Lines                   ?    19365           
  Branches                ?        0           
===============================================
  Hits                    ?    16599           
  Misses                  ?     2766           
  Partials                ?        0
Flag Coverage Δ
dask 46.48% <0.00%> (?)
non-dask 78.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818bd25...86db099. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 1cc48df into rapidsai:branch-22.04 Feb 3, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 3, 2022
@lowener lowener deleted the 22.04-onehot-fix branch February 3, 2022 16:43
cjnolet added a commit to cjnolet/cuml that referenced this pull request Feb 4, 2022
@cjnolet
Revert "Fix compatibility of OneHotEncoder fit (rapidsai#4544)"
7dec869 
This reverts commit 1cc48df.
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Fix compatibility of OneHotEncoder fit (rapidsai#4544)
daa0a9f 
Fix rapidsai#4426

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cuML Pipeline fit fails with cuML OneHotEncoder but not sklearn OneHotEncoder
3 participants
@lowener @dantegd @codecov-commenter