Moving cusparse wrappers to detail API in RAFT. #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
3 - Ready for Review
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
dantegd
requested changes
Feb 3, 2022
cpp/cmake/thirdparty/get_raft.cmake
Outdated
| @@ -57,8 +57,8 @@ set(CUML_BRANCH_VERSION_raft "${CUML_VERSION_MAJOR}.${CUML_VERSION_MINOR}") | |||
| # To use a different RAFT locally, set the CMake variable | |||
| # CPM_raft_SOURCE=/path/to/local/raft | |||
| find_and_configure_raft(VERSION ${CUML_MIN_VERSION_raft} | |||
| FORK rapidsai | |||
| PINNED_TAG branch-${CUML_BRANCH_VERSION_raft} | |||
| FORK cjnolet | |||
There was a problem hiding this comment.
reminder to change this back before merging
cpp/src/glm/qn/simple_mat/sparse.hpp
Outdated
| @@ -25,10 +25,13 @@ | |||
| #include <raft/handle.hpp> | |||
| #include <raft/linalg/binary_op.cuh> | |||
| #include <raft/linalg/cublas_wrappers.h> | |||
|
|
|||
| // TODO: Need to wrap the cusparse functions in the RAFT public API | |||
There was a problem hiding this comment.
Is there a RAFT issue to track it?
There was a problem hiding this comment.
There is: rapidsai/raft#475
dantegd
approved these changes
Feb 8, 2022
dantegd
approved these changes
Feb 8, 2022
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4547 +/- ##
===============================================
Coverage ? 85.70%
===============================================
Files ? 236
Lines ? 19363
Branches ? 0
===============================================
Hits ? 16596
Misses ? 2767
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This will require a follow-on to expose corresponding functions through the RAFT public API, but that's also the case for some cublas/cusolver calls currently so we'll scrape through and do that all at once Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require a follow-on to expose corresponding functions through the RAFT public API, but that's also the case for some cublas/cusolver calls currently so we'll scrape through and do that all at once