Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to consistency of MNMG PCA/TSVD solvers (docs + code consolidation) #4556

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Updates to consistency of MNMG PCA/TSVD solvers (docs + code consolidation) #4556

merged 7 commits into from
Mar 17, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 4, 2022

No description provided.

@cjnolet cjnolet added doc Documentation non-breaking Non-breaking change labels Feb 4, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 4, 2022 23:41
@cjnolet cjnolet added this to PR-WIP in v22.04 Release via automation Feb 4, 2022
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 4, 2022
v22.04 Release automation moved this from PR-WIP to PR-Needs review Feb 7, 2022
lowener
lowener requested changes Feb 7, 2022
View reviewed changes
python/cuml/decomposition/tsvd_mg.pyx Outdated Show resolved Hide resolved
@cjnolet cjnolet requested a review from a team as a code owner February 13, 2022 18:30
v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Mar 15, 2022
lowener
lowener approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member Author

cjnolet commented Mar 17, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@05a9c16). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04    #4556   +/-   ##
===============================================
  Coverage                ?   83.86%           
===============================================
  Files                   ?      251           
  Lines                   ?    20293           
  Branches                ?        0           
===============================================
  Hits                    ?    17019           
  Misses                  ?     3274           
  Partials                ?        0
Flag Coverage Δ
dask 44.92% <0.00%> (?)
non-dask 77.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a9c16...d05d155. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Mar 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 48120ce into rapidsai:branch-22.04 Mar 17, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Mar 17, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Updates to consistency of MNMG PCA/TSVD solvers (docs + code consolid…
355147a 
…ation) (rapidsai#4556)

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Micka (https://github.com/lowener)

URL: rapidsai#4556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@lowener lowener lowener approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjnolet @codecov-commenter @dantegd @lowener