Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTING] Adding libraft conda dependencies #4564

Merged
merged 8 commits into from
Feb 19, 2022
Merged

[TESTING] Adding libraft conda dependencies #4564

merged 8 commits into from
Feb 19, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 8, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 8, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 8, 2022 16:29
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Feb 8, 2022
@cjnolet cjnolet added this to PR-WIP in v22.04 Release via automation Feb 8, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 8, 2022

rerun tests

1 similar comment
@jjacobelli
Copy link
Contributor

rerun tests

@cjnolet cjnolet requested a review from a team as a code owner February 10, 2022 18:59
@cjnolet
Revert "More fixes"
d4095b1 
This reverts commit 9e31239.
@github-actions github-actions bot removed the CUDA/C++ label Feb 10, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 18, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Feb 18, 2022

rerun tests

msadang
msadang approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 19, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 19, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@cbe4beb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4564   +/-   ##
===============================================
  Coverage                ?   83.87%           
===============================================
  Files                   ?      250           
  Lines                   ?    20052           
  Branches                ?        0           
===============================================
  Hits                    ?    16819           
  Misses                  ?     3233           
  Partials                ?        0
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.96% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe4beb...5432e76. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 647f7cd into rapidsai:branch-22.04 Feb 19, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 19, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Adding libraft conda dependencies (rapidsai#4564)
9f5b370 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Mark Sadang (https://github.com/msadang)

URL: rapidsai#4564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@msadang msadang msadang approved these changes

Assignees
No one assigned
Labels
conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cjnolet @jjacobelli @codecov-commenter @dantegd @msadang