Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving more ling prims to raft #4567

Merged
merged 36 commits into from
Feb 11, 2022
Merged

Moving more ling prims to raft #4567

merged 36 commits into from
Feb 11, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 9, 2022

No description provided.

vinaydes and others added 23 commits February 1, 2022 15:01
@vinaydes
Pointing to custom RAFT
221d87c
@vinaydes
Doing the modifications needed to work with new RAFT RNG
6843958
@cjnolet
cuml updates for lap, label, cluster, and spectral apis
2d8f486
@cjnolet
Updating raft pin
5902b07
@cjnolet
Updating copyrights
fc41d8f
@vinaydes
Merge branch 'branch-22.04' into for-raft-rng-improvements
f5acca5
@vinaydes
Converting to ceil division
9a7633b
@vinaydes
Fixing the issue with RF text dump test
d4c2dd1
@vinaydes
Increasing the number of SVD components to make the test work with ot…
fc58e51 
…her RNGs
@vinaydes
Fixing SVD tests by introducing some redundancy
a34953a
@vinaydes
Fixing format
ddf80fb
@cjnolet
Merge remote-tracking branch 'rapidsai/branch-22.04' into imp-2204-la…
4e740d5 
…p_label_cluster_spectral_updates
@cjnolet
Fixing raft::spasrse calls
ec44e7c
@cjnolet
Reverting raft pin
bb3fad4
@vinaydes
Merge branch 'branch-22.04' into for-raft-rng-improvements
10ce2a6
@vinaydes
Merge remote-tracking branch 'cjnolet/imp-2204-lap_label_cluster_spec…
6b7217b 
…tral_updates' into for-raft-rng-improvements
@vinaydes
Fixing the random number generator initialization
50b6d99
@vinaydes
Update RAFT commit id
91b6f89
@cjnolet
Merge branch 'branch-22.04' into for-raft-rng-improvements
c609f7a
@cjnolet
Merge branch 'branch-22.04' into for-raft-rng-improvements
898c3a7
@cjnolet
Moving more linalg prims to raft
7d98f03
@cjnolet
Updating raft pin
ea6bb6d
@cjnolet
Updating style
e705441
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 9, 2022
@cjnolet cjnolet requested review from a team as code owners February 9, 2022 23:56
@cjnolet cjnolet added this to PR-WIP in v22.04 Release via automation Feb 9, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 10, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Feb 10, 2022

rerun tests

dantegd
dantegd requested changes Feb 10, 2022
View reviewed changes
cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
v22.04 Release automation moved this from PR-WIP to PR-Needs review Feb 10, 2022
v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Feb 10, 2022
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 11, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 11, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@7ab0f4c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4567   +/-   ##
===============================================
  Coverage                ?   83.87%           
===============================================
  Files                   ?      250           
  Lines                   ?    20070           
  Branches                ?        0           
===============================================
  Hits                    ?    16833           
  Misses                  ?     3237           
  Partials                ?        0
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab0f4c...d127221. Read the comment docs.

@rapids-bot rapids-bot bot merged commit d0459ef into rapidsai:branch-22.04 Feb 11, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 11, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Moving more ling prims to raft (rapidsai#4567)
a7a163b 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Vinay Deshpande (https://github.com/vinaydes)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
breaking Breaking change CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjnolet @codecov-commenter @dantegd @vinaydes