Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining stats prims to raft #4568

Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 10, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 10, 2022
@cjnolet cjnolet requested review from a team as code owners February 10, 2022 22:38
@cjnolet cjnolet added this to PR-WIP in v22.04 Release via automation Feb 10, 2022
@github-actions github-actions bot added CMake CUDA/C++ Cython / Python Cython or Python issue labels Feb 10, 2022
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,

@@ -57,8 +57,8 @@ set(CUML_BRANCH_VERSION_raft "${CUML_VERSION_MAJOR}.${CUML_VERSION_MINOR}")
# To use a different RAFT locally, set the CMake variable
# CPM_raft_SOURCE=/path/to/local/raft
find_and_configure_raft(VERSION ${CUML_MIN_VERSION_raft}
FORK rapidsai
PINNED_TAG branch-${CUML_BRANCH_VERSION_raft}
FORK vinaydes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the obligatory comment to change back this

v22.04 Release automation moved this from PR-WIP to PR-Needs review Feb 10, 2022
@github-actions github-actions bot removed the Cython / Python Cython or Python issue label Feb 11, 2022
v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Feb 12, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@d0459ef). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4568   +/-   ##
===============================================
  Coverage                ?   83.87%           
===============================================
  Files                   ?      250           
  Lines                   ?    20070           
  Branches                ?        0           
===============================================
  Hits                    ?    16833           
  Misses                  ?     3237           
  Partials                ?        0           
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0459ef...a346f94. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Feb 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 449d5ea into rapidsai:branch-22.04 Feb 12, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 12, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants