Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conda compilers #4577

Merged
merged 1 commit into from
May 21, 2022
Merged

Use conda compilers #4577

merged 1 commit into from
May 21, 2022

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Feb 14, 2022 •
edited

This PR enables the usage of conda compilers to build conda packages. This is required to use mambabuild

@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 14, 2022
@jjacobelli jjacobelli self-assigned this Feb 14, 2022
@github-actions github-actions bot added the conda conda issue label Feb 14, 2022
@jjacobelli jjacobelli added this to PR-WIP in v22.04 Release via automation Feb 14, 2022
@trivialfis
Copy link
Member

nvcc is available on conda now?

@jjacobelli
Copy link
Contributor Author

nvcc is available on conda now?

The nvcc_linux-* packages are just wrappers around the nvcc provided by the nvidia/cuda docker images

@jjacobelli jjacobelli force-pushed the conda-comp branch 3 times, most recently from 9742812 to 49b6f9b Compare February 23, 2022 15:01
@github-actions github-actions bot added the gpuCI gpuCI issue label Feb 23, 2022
@jjacobelli jjacobelli force-pushed the conda-comp branch 16 times, most recently from 23e3e27 to c7ea976 Compare March 2, 2022 16:42
@jjacobelli jjacobelli changed the base branch from branch-22.04 to branch-22.06 March 24, 2022 09:18
@jjacobelli jjacobelli removed this from PR-WIP in v22.04 Release Mar 24, 2022
@jjacobelli jjacobelli added this to PR-WIP in v22.06 Release via automation Mar 24, 2022
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@jjacobelli jjacobelli force-pushed the conda-comp branch 2 times, most recently from 44772b2 to 63ed48c Compare May 10, 2022 12:58
@jjacobelli jjacobelli marked this pull request as ready for review May 20, 2022 19:37
@jjacobelli jjacobelli requested a review from a team as a code owner May 20, 2022 19:37
v22.06 Release automation moved this from PR-WIP to PR-Reviewer approved May 20, 2022
ajschmidt8
ajschmidt8 approved these changes May 20, 2022
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
conda/recipes/libcuml/meta.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the gpuCI gpuCI issue label May 20, 2022
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@jjacobelli
Use conda compilers
f77751a 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4577 (f77751a) into branch-22.06 (15aba09) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.06    #4577   +/-   ##
=============================================
  Coverage         79.89%   79.89%           
=============================================
  Files               180      180           
  Lines             11371    11371           
=============================================
  Hits               9085     9085           
  Misses             2286     2286
Flag Coverage Δ
dask 45.45% <ø> (ø)
non-dask 69.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15aba09...f77751a. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 3e3a1e0 into rapidsai:branch-22.06 May 21, 2022
v22.06 Release automation moved this from PR-Reviewer approved to Done May 21, 2022
@ajschmidt8 ajschmidt8 mentioned this pull request Jun 6, 2022
Merged
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@jjacobelli
Use conda compilers (rapidsai#4577)
a0464a9 
This PR enables the usage of conda compilers to build conda packages. This is required to use `mambabuild`

Authors:
  - Jordan Jacobelli (https://github.com/Ethyling)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@jjacobelli jjacobelli

Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jjacobelli @trivialfis @codecov-commenter @ajschmidt8