Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix the TargetEncoder when transforming dataframe/series with custom index #4578

Merged
merged 12 commits into from
Feb 16, 2022

Conversation

daxiongshu
Copy link
Contributor

This PR fixes the error raised in issue #4572

@daxiongshu daxiongshu requested a review from a team as a code owner February 14, 2022 19:53
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 14, 2022
@daxiongshu daxiongshu added non-breaking Non-breaking change bug Something isn't working labels Feb 14, 2022
@daxiongshu daxiongshu changed the title Fix the TargetEncoder when transforming dataframe/series with custom index [WIP] Fix the TargetEncoder when transforming dataframe/series with custom index Feb 14, 2022
@caryr35 caryr35 added this to PR-WIP in v22.04 Release via automation Feb 15, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.04 Release Feb 15, 2022
@dantegd
Copy link
Member

dantegd commented Feb 16, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@9e0d458). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4578   +/-   ##
===============================================
  Coverage                ?   83.91%           
===============================================
  Files                   ?      251           
  Lines                   ?    20126           
  Branches                ?        0           
===============================================
  Hits                    ?    16888           
  Misses                  ?     3238           
  Partials                ?        0           
Flag Coverage Δ
dask 45.15% <0.00%> (?)
non-dask 77.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0d458...a3ddd6d. Read the comment docs.

@daxiongshu daxiongshu changed the title [WIP] Fix the TargetEncoder when transforming dataframe/series with custom index [REVIEW] Fix the TargetEncoder when transforming dataframe/series with custom index Feb 16, 2022
v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Feb 16, 2022
@dantegd
Copy link
Member

dantegd commented Feb 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b8020bd into rapidsai:branch-22.04 Feb 16, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 16, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
…index (rapidsai#4578)

This PR fixes the error raised in issue rapidsai#4572

Authors:
  - Jiwei Liu (https://github.com/daxiongshu)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants