Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing FAISS license #4579

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 14, 2022

Somehow this file never got checked in and @trivialfis happened to notice as we were going through the process of adding license for mdarray in RAFT.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 14, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 14, 2022 20:05
@cjnolet cjnolet added this to PR-WIP in v22.04 Release via automation Feb 14, 2022
v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 14, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@9e0d458). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4579   +/-   ##
===============================================
  Coverage                ?   83.87%           
===============================================
  Files                   ?      250           
  Lines                   ?    20070           
  Branches                ?        0           
===============================================
  Hits                    ?    16833           
  Misses                  ?     3237           
  Partials                ?        0           
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0d458...8f2dc46. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Feb 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 88e41e8 into rapidsai:branch-22.04 Feb 15, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 15, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Somehow this file never got checked in and @trivialfis happened to notice as we were going through the process of adding license for `mdarray` in RAFT.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants