Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for nightly CI tests: Use CUDA_REL variable in gpu build.sh script #4581

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Fix for nightly CI tests: Use CUDA_REL variable in gpu build.sh script #4581

merged 2 commits into from
Feb 16, 2022

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Feb 15, 2022

No description provided.

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Feb 15, 2022
@dantegd dantegd requested review from a team as code owners February 15, 2022 19:31
@dantegd dantegd added this to PR-WIP in v22.04 Release via automation Feb 15, 2022
@github-actions github-actions bot added Cython / Python Cython or Python issue gpuCI gpuCI issue labels Feb 15, 2022
@dantegd
Copy link
Member Author

dantegd commented Feb 15, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Feb 15, 2022

I have the fix building now on the RAFT side: rapidsai/raft#509 so we shouldn't need to increase the threshold. We should actually be able to lower it to 0.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@88e41e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4581   +/-   ##
===============================================
  Coverage                ?   83.87%           
===============================================
  Files                   ?      250           
  Lines                   ?    20052           
  Branches                ?        0           
===============================================
  Hits                    ?    16819           
  Misses                  ?     3233           
  Partials                ?        0
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.96% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e41e8...7683fc0. Read the comment docs.

v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 16, 2022
@cjnolet
Copy link
Member

cjnolet commented Feb 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 52a7d00 into rapidsai:branch-22.04 Feb 16, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 16, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Fix for nightly CI tests: Use CUDA_REL variable in gpu build.sh script (
41f0b79 
rapidsai#4581)

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: rapidsai#4581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue gpuCI gpuCI issue non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dantegd @cjnolet @codecov-commenter @jjacobelli