Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Complement Naive Bayes #4595

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Add Complement Naive Bayes #4595

merged 5 commits into from
Mar 7, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Feb 21, 2022

Closes #1666.
The implementation of this variant is straightforward and matches sklearn.

@lowener lowener requested a review from a team as a code owner February 21, 2022 19:21
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 21, 2022
@lowener lowener added 3 - Ready for Review Ready for review by team feature request New feature or request labels Feb 21, 2022
@caryr35 caryr35 added this to PR-WIP in v22.04 Release via automation Feb 22, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.04 Release Feb 22, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@647f7cd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4595   +/-   ##
===============================================
  Coverage                ?   83.89%           
===============================================
  Files                   ?      250           
  Lines                   ?    20098           
  Branches                ?        0           
===============================================
  Hits                    ?    16861           
  Misses                  ?     3237           
  Partials                ?        0
Flag Coverage Δ
dask 45.13% <0.00%> (?)
non-dask 77.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647f7cd...b3db4a7. Read the comment docs.

cjnolet
cjnolet approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks really good. Other than validating the robustness to skew, I didn't find anything major. Very straightforward clean implementation.

python/cuml/test/test_naive_bayes.py Outdated Show resolved Hide resolved
v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Feb 24, 2022
@lowener lowener added the non-breaking Non-breaking change label Mar 2, 2022
@cjnolet
Copy link
Member

cjnolet commented Mar 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2b0c200 into rapidsai:branch-22.04 Mar 7, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Mar 7, 2022
@lowener lowener deleted the 22.04-nb-complement branch March 7, 2022 16:50
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Add Complement Naive Bayes (rapidsai#4595)
68a5e36 
Closes rapidsai#1666.
The implementation of this variant is straightforward and matches sklearn.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support Naive Bayes variants
3 participants
@lowener @codecov-commenter @cjnolet